Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure GitHub Actions and pre-commit hooks are pinned #2576

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 5, 2025

Apache wants us to limit concurrency, ensure actions are pinned, and ensure we aren't exporting GITHUB_TOKEN etc. (https://infra.apache.org/github-actions-policy.html) It's not clear to me if our use of GITHUB_TOKEN in dev_pr.yaml falls under that.

Fixes #2575.

@lidavidm lidavidm added this to the ADBC Libraries 18 milestone Mar 5, 2025
@lidavidm lidavidm marked this pull request as ready for review March 5, 2025 03:38
@lidavidm lidavidm requested a review from zeroshade as a code owner March 5, 2025 03:38
@lidavidm
Copy link
Member Author

@kou or @zeroshade, any more comments here?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lidavidm
Copy link
Member Author

@paleolimbot am I right in thinking the failures are actual problems? (Also, I think you've brought up that Snowflake logging output before...we should report upstream/try to suppress it)

@paleolimbot
Copy link
Member

Hmm..that's a very strange error. It's not an actual problem in the sense that I don't think anything is not working, there must be something about the output that's being generated from the example or test that R CMD check doesn't know what to do with. I will take a look today.

@paleolimbot
Copy link
Member

Ok, the offending error message is:

time="2025-03-11T12:51:47Z" level=info msg="Credentials cache path: /home/runner/.cache/snowflake/temporary_credential.json" func="gosnowflake.(*defaultLogger).Infof" file="log.go:182"

In R you're not supposed to write to stderr directly, you're supposed to write to R's specific stderr stream (so that those messages can be captured by R things), and I am wondering if something in R CMD check is getting some mashup of the log message and what it intended to read by accident. This doesn't reproduce locally for me (maybe because I have no credentials when I run the examples, though).

This is probably unrelated to this particular change (the R checks maybe haven't run on main for a while since I haven't updated anything 😬 ). I'll open a follow-up (and maybe a short-term solution would be to set the log level to warning rather than info?).

@lidavidm
Copy link
Member Author

Thanks for digging into it!

I think the log message is coming from gosnowflake, though, so maybe the easiest thing is just a PR to remove the stray log (I can do this in a bit)

@lidavidm
Copy link
Member Author

Filed snowflakedb/gosnowflake#1332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: ensure compliance with Apache policy
4 participants